don't leak goroutines when pings complete #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kubuxu wanna CR for me? |
|
LGTM, this change will solve the currently reported issue but rest will prevent leaks in general. Nice. |
|
This LGTM as an adhoc fix, but longer term we should aim for making this independent of time, e.g. by allowing one ping per peer, and aborting earlier pings when a new ping comes in. |
marten-seemann
added a commit
that referenced
this pull request
Apr 19, 2022
emit the EvtPeerConnectednessChanged event
marten-seemann
pushed a commit
that referenced
this pull request
Apr 26, 2022
marten-seemann
added a commit
that referenced
this pull request
Aug 15, 2022
marten-seemann
pushed a commit
that referenced
this pull request
Aug 17, 2022
This drops the opensensus dependency. Nobody uses this, from what I can tell. fixes #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.