This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat!: add observed address methods #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we observe an address that might be externally dialable (via identify or uPNP NAT holepunching, etc), we need some way of signalling that we've either verified it's externally dialable and that we are safe to advertise it, or that it's not dialable and that we should forget about it. These methods are necessary to implement autonat.
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jul 19, 2022
Implements the [autonat](https://github.com/libp2p/specs/blob/master/autonat/README.md) spec to give us confidence in our external addresses and to open the door to things like switching DHT server mode on automatically, hole punching, v2 circuit relay etc. Depends on: - [ ] libp2p/js-libp2p-interfaces#269
1 task
wemeetagain
approved these changes
Jul 19, 2022
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
## [@libp2p/interface-address-manager-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-address-manager-v1.0.3...@libp2p/interface-address-manager-v2.0.0) (2022-10-07) ### ⚠ BREAKING CHANGES * add observed address methods (#269) ### Features * add observed address methods ([#269](#269)) ([0b157d5](0b157d5))
|
🎉 This PR is included in version @libp2p/interface-address-manager-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Mar 14, 2023
Implements the [autonat](https://github.com/libp2p/specs/blob/master/autonat/README.md) spec to give us confidence in our external addresses and to open the door to things like switching DHT server mode on automatically, hole punching, v2 circuit relay etc. Depends on: - [x] libp2p/js-libp2p-interfaces#269 Fixes #1005
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we observe an address that might be externally dialable (via identify or uPNP NAT holepunching, etc), we need some way of signalling that we've either verified it's externally dialable and that we are safe to advertise it, or that it's not dialable and that we should forget about it.
These methods are necessary to implement autonat.