Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: emit event on peer connected #66

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Dec 24, 2018

Add emit event on peer connected.

Required by #61

@vasco-santos vasco-santos force-pushed the feat/emit-event-on-peer-connected branch from 07a79c4 to 1066f06 Compare January 28, 2019 11:58
@vasco-santos vasco-santos changed the title [WIP] feat: emit event on peer connected feat: emit event on peer connected Jan 28, 2019
@jacobheun
Copy link
Contributor

@vasco-santos can you elaborate on how this closes #61, I don't quite follow?

Also, I don't think js-libp2p is actually listening for peer events on the dht, since it has yet to be added as an actual peerDiscovery service. Is something else handling the listening?

@vasco-santos
Copy link
Member Author

vasco-santos commented Jan 28, 2019

Sorry @jacobheun , I should have been more clear.

This is part of a set of PRs:

These PRs are not ready yet

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I went ahead and updated your PR description to "required by" instead of "closes" so Waffle doesn't close that issue, since it's technically not fixed until the other issues are done.

@vasco-santos vasco-santos merged commit ba0a537 into master Feb 5, 2019
@ghost ghost removed the status/in-progress In progress label Feb 5, 2019
@vasco-santos vasco-santos deleted the feat/emit-event-on-peer-connected branch February 5, 2019 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants