feat: allow keychain interactions without a password #25
Conversation
ghost
assigned 
|
In my honest opinion, But since we have a different approach from the What do you think? |
|
My feeling is that requiring the password for all interactions is a bit heavy handed - the password is not required by the code to list keys in the keychain for example. |
|
perhaps a flag to allow a user to set a password, similar to how SSH prompts for a password but doesn't require it? |
achingbrain
changed the title
| @@ -25,7 +25,8 @@ const defaultOptions = { | |||
| iterationCount: 10000, | |||
| salt: 'you should override this value with a crypto secure random number', | |||
| hash: 'sha2-512' | |||
| } | |||
| }, | |||
| passPhrase: 'correcthorsebatterystaple' | |||
There was a problem hiding this comment.
What if the default password is just empty string?
There was a problem hiding this comment.
The code later enforces that the password should be 20+ characters long.
|
Closing because this is very old and probably not a good idea. |
Possibly contentious PR, but go-ipfs does not require a password to list or generate keys but js-ipfs does. This prevents us from having interop as the behaviour is different.
This PR sets a silly default password to enable this but I'm not 100% convinced any of this is a good idea.
Needed for the tests in ipfs/js-ipfs#1548 and ipfs/interop#35 to pass.