This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix: Update splitAddr function to correctly parse multiaddrs #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-shahi
changed the title
maschad
approved these changes
Jun 1, 2023
maschad
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
## [2.0.5](v2.0.4...v2.0.5) (2023-06-01) ### Bug Fixes * Update splitAddr function to correctly parse multiaddrs ([#174](#174)) ([22a7029](22a7029))
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #171
Dialing a peer with a multiaddr that contains both
/webrtc-directand/webrtcresults inCodeError: webrtc protocol was not present in multiaddr. when the multiaddr is perfectly valid. For example:/ip4/127.0.0.1/udp/9090/webrtc-direct/certhash/uEiBUr89tH2P9paTCPn-AcfVZcgvIvkwns96t4h55IpxFtA/p2p/12D3KooWB64sJqc3T3VCaubQCrfCvvfummrAA9z1vEXHJT77ZNJh/p2p-circuit/webrtc/p2p/12D3KooWFNBgv86tcpcYUHQz9FWGTrTmpMgr8feZwQXQySVTo3A7