Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky tests #1134

Closed
achingbrain opened this issue Jan 20, 2022 · 0 comments · Fixed by #1137
Closed

Flaky tests #1134

achingbrain opened this issue Jan 20, 2022 · 0 comments · Fixed by #1137
Labels
need/triage Needs initial labeling and prioritization

Comments

@achingbrain
Copy link
Member 

  1) auto-relay
       flows with 1 listener max
         should try to listen on stored peers relayed address if one used relay disconnects and there are not enough connected:

      AssertionError: expected 0 to equal 1
      + expected - actual

      -0
      +1
      
      at Context.<anonymous> (test/relay/auto-relay.node.js:374:48)
@achingbrain achingbrain added the need/triage Needs initial labeling and prioritization label Jan 20, 2022
achingbrain added a commit that referenced this issue Jan 21, 2022
@achingbrain
chore: fix flaky tests
adf9985 
These tests are flaky in CI, probably due to differences in timing
introduced by #1058

Fixes #1134
@achingbrain achingbrain mentioned this issue Jan 21, 2022
Merged
achingbrain added a commit that referenced this issue Jan 21, 2022
@achingbrain
chore: fix flaky tests (#1137)
4c3bf01 
These tests are flaky in CI, probably due to differences in timing introduced by #1058

Fixes #1134
@adamlaska adamlaska mentioned this issue Feb 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix flaky tests libp2p/js-libp2p
1 participant
@achingbrain