Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control inbound/outbound connection limits separately #1508

Closed
achingbrain opened this issue Dec 4, 2022 · 3 comments
Closed

Control inbound/outbound connection limits separately #1508

achingbrain opened this issue Dec 4, 2022 · 3 comments
Assignees
@maschad
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue

Comments

@achingbrain
Copy link
Member

achingbrain commented Dec 4, 2022 •
edited by BigLep
Loading

Currently the connection manager has settings such as maxConnections and minConnections - these are applied to both incoming and outgoing connections together. A user should be able to apply these limits to inbound and outbound connections separately.

Note: when this done we should also update doc/LIMITS.md per #1456
@achingbrain achingbrain added the need/triage Needs initial labeling and prioritization label Dec 4, 2022
This was referenced Dec 4, 2022
Merged
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 5, 2022
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
33a36da 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 5, 2022
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
5e2eb57 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 5, 2022
@maschad
feat: Added the configuration capabilities on connection manager to s…
e32a7ec 
…eperate incoming and outgoing connection limits (libp2p#1508)
@maschad maschad mentioned this issue Dec 5, 2022
Closed
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 5, 2022
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
a3fe36c 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 5, 2022
@maschad
feat: Added the configuration capabilities on connection manager to s…
1f522e0 
…eperate incoming and outgoing connection limits (libp2p#1508)
@achingbrain achingbrain added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization labels Dec 6, 2022
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 6, 2022
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
f22ef61 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 6, 2022
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
b5b1640 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 6, 2022
@maschad
feat: Added the configuration capabilities on connection manager to s…
456dc62 
…eperate incoming and outgoing connection limits (libp2p#1508)
@p-shahi p-shahi mentioned this issue Dec 10, 2022
Closed
3 tasks
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
f8e0b7c 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
dc25fc3 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
feat: Added the configuration capabilities on connection manager to s…
9b4424e 
…eperate incoming and outgoing connection limits (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 15, 2022
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
cbeecdd 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 15, 2022
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
eef33cf 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 15, 2022
@maschad
feat: Added the configuration capabilities on connection manager to s…
5a2342c 
…eperate incoming and outgoing connection limits (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 16, 2022
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
24f864f 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 16, 2022
@maschad
feat: Added the configuration capabilities on connection manager to s…
79bff2c 
…eperate incoming and outgoing connection limits (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 3, 2023
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
510285a 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 3, 2023
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
2fd541a 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 3, 2023
@maschad
feat: Added the configuration capabilities on connection manager to s…
4c6112f 
…eperate incoming and outgoing connection limits (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 4, 2023
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
25c0621 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 4, 2023
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
65add00 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 4, 2023
@maschad
feat: Added the configuration capabilities on connection manager to s…
b88493a 
…eperate incoming and outgoing connection limits (libp2p#1508)
@BigLep
Copy link
Contributor

BigLep commented Jan 7, 2023

@p-shahi : it looks like @maschad is working on this issue. Can we get him set as the assignee (I assume we need to add him to the org)?

maschad added a commit to maschad/js-libp2p that referenced this issue Jan 7, 2023
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
a69a176 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 7, 2023
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
4d857a6 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 7, 2023
@maschad
feat: Added the configuration capabilities on connection manager to s…
f576afb 
…eperate incoming and outgoing connection limits (libp2p#1508)
@maschad
Copy link
Member

maschad commented Jan 7, 2023

@p-shahi : it looks like @maschad is working on this issue. Can we get him set as the assignee (I assume we need to add him to the org)?

the PR is ready for review, looks like @p-shahi already requested a review from @achingbrain 👍🏾 Thanks @BigLep

maschad added a commit to maschad/js-libp2p that referenced this issue Jan 16, 2023
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
836a5af 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 16, 2023
@maschad
test: updated tests to check for max/min incoming and outgoing connec…
b8bb367 
…tions from connection manager (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 16, 2023
@maschad
feat: Added the configuration capabilities on connection manager to s…
d2cad14 
…eperate incoming and outgoing connection limits (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 18, 2023
@maschad
fixup! doc: Updated docs to seperate max/min incoming and outgoing co…
b534c8b 
…nnections (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 18, 2023
@maschad
fixup! feat: Added the configuration capabilities on connection manag…
e2810db 
…er to seperate incoming and outgoing connection limits (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 18, 2023
@maschad
doc: Updated docs to seperate max/min incoming and outgoing connectio…
5b2c1f0 
…ns (libp2p#1508)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 24, 2023
@maschad
test: updated test for outbound connection limits (libp2p#1508)
c8ebca5
@maschad maschad self-assigned this Feb 6, 2023
@maschad
Copy link
Member

maschad commented Feb 7, 2023

Closing this in light of the discussion here

@maschad maschad closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
3 participants
@BigLep @achingbrain @maschad