fix: use placeholder dht/pubsub #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of making the `.dht` and `.pubsub` properties optional, use dummy implementations that throw exceptions if they are not configured. This way we don't have to null guard everywhere they are accessed.
achingbrain
added a commit
to libp2p/js-libp2p-interfaces
that referenced
this pull request
Apr 28, 2022
Since libp2p/js-libp2p#1193 there will be values for pubsub and dht so no need to return them as maybe-undefined.
achingbrain
added a commit
to libp2p/js-libp2p-interfaces
that referenced
this pull request
Apr 28, 2022
Since libp2p/js-libp2p#1193 there will be values for pubsub and dht so no need to return them as maybe-undefined. Also make mock-muxer logs a little less chatty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making the
.dhtand.pubsubproperties optional, use dummy implementations that throw exceptions if they are not configured.This way we don't have to null guard everywhere they are accessed.