Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert WebRTC message size increase #2679

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: revert WebRTC message size increase #2679

merged 1 commit into from
Sep 4, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Sep 4, 2024 •
edited
Loading

go-libp2p and rust-libp2p close incoming streams when the message size is greater than 16KiB so reset to the previous limit.

Reverts #2627

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: revert WebRTC message size increase
8f727be 
go-libp2p and rust-libp2p close incoming streams when the message
size is greater than 16KiB so reset to the previous limit.
@achingbrain achingbrain requested a review from a team as a code owner September 4, 2024 10:20
@achingbrain achingbrain merged commit 2265e59 into main Sep 4, 2024
25 checks passed
@achingbrain achingbrain deleted the fix/revert-webrtc-message-size-increase branch September 4, 2024 11:17
@achingbrain achingbrain mentioned this pull request Sep 4, 2024
Merged
@2color 2color mentioned this pull request Sep 5, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain