Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transport manager fault tolerance should include tolerance to transport listen fail #893

Conversation

vasco-santos
Copy link
Member

When we added a fault tolerance option to libp2p's transport manager, this only included a scenario where the provided multiaddrs were not compatible to the configured transport resulting in no listen multiaddrs used to create listeners in the transports.

This fault tolerance should also include tolerance for failure on trying to listen on multiaddrs that are compatible with the configured transport but the listen fails. This is specially important for remote listeners like relays and webrtc signal servers.

Context: ipfs-shipyard/ipfs-share-files#121

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with ipfs-shipyard/ipfs-share-files#121 and works as expected:

2021-02-25--15-13-32

@vasco-santos Is it possible to ship this as a patch release?

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos vasco-santos merged commit 3f314d5 into master Feb 25, 2021
@vasco-santos vasco-santos deleted the fix/transport-manager-fault-tolerance-should-include-tolerance-to-transport-listen-fail branch February 25, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants