Skip to content

Commit

Permalink
chore(quic): set max_idle_timeout to quinn default timeout
Browse files Browse the repository at this point in the history
Resolves #4917.

Pull-Request: #4965.
  • Loading branch information
dariusc93 committed Dec 1, 2023
1 parent d8d5482 commit 9584ee3
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ libp2p-perf = { version = "0.3.0", path = "protocols/perf" }
libp2p-ping = { version = "0.44.0", path = "protocols/ping" }
libp2p-plaintext = { version = "0.41.0", path = "transports/plaintext" }
libp2p-pnet = { version = "0.24.0", path = "transports/pnet" }
libp2p-quic = { version = "0.10.1", path = "transports/quic" }
libp2p-quic = { version = "0.10.2", path = "transports/quic" }
libp2p-relay = { version = "0.17.1", path = "protocols/relay" }
libp2p-rendezvous = { version = "0.14.0", path = "protocols/rendezvous" }
libp2p-request-response = { version = "0.26.1", path = "protocols/request-response" }
Expand Down
5 changes: 5 additions & 0 deletions transports/quic/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.10.2

- Change `max_idle_timeout`to 10s.
See [PR XXXX](https://github.com/libp2p/rust-libp2p/pull/XXXX).

This comment has been minimized.

Copy link
@divagant-martian

divagant-martian Dec 11, 2023

Contributor

it looks like this made it into the changelog without being updated

This comment has been minimized.

Copy link
@thomaseizinger

thomaseizinger Dec 11, 2023

Contributor

Thanks! Fixed in #4993.


## 0.10.1

- Allow disabling path MTU discovery.
Expand Down
2 changes: 1 addition & 1 deletion transports/quic/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "libp2p-quic"
version = "0.10.1"
version = "0.10.2"
authors = ["Parity Technologies <admin@parity.io>"]
edition = "2021"
rust-version = { workspace = true }
Expand Down
4 changes: 2 additions & 2 deletions transports/quic/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ impl Config {
server_tls_config,
support_draft_29: false,
handshake_timeout: Duration::from_secs(5),
max_idle_timeout: 30 * 1000,
max_idle_timeout: 10 * 1000,
max_concurrent_stream_limit: 256,
keep_alive_interval: Duration::from_secs(15),
keep_alive_interval: Duration::from_secs(5),
max_connection_data: 15_000_000,

// Ensure that one stream is not consuming the whole connection.
Expand Down

0 comments on commit 9584ee3

Please sign in to comment.