Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm-derive/: Replace mentions of ProtocolsHandler with ConnectionHandler #2637

Closed
mxinden opened this issue May 10, 2022 · 1 comment · Fixed by #2640
Closed

swarm-derive/: Replace mentions of ProtocolsHandler with ConnectionHandler #2637

mxinden opened this issue May 10, 2022 · 1 comment · Fixed by #2640
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Comments

@mxinden
Copy link
Member

mxinden commented May 10, 2022

ProtocolsHandler has been renamed to ConnectionHandler, see #2527. Unfortunately I missed to patch swarm-derive, for example the line below.

rust-libp2p/swarm-derive/src/lib.rs

Line 54 in 5cf6890

let protocols_handler = quote! {::libp2p::swarm::ConnectionHandler};

@mxinden mxinden added difficulty:easy help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels May 10, 2022
@maschad maschad mentioned this issue May 11, 2022
Merged
4 tasks
@maschad
Copy link
Member

maschad commented May 11, 2022

ProtocolsHandler has been renamed to ConnectionHandler, see #2527. Unfortunately I missed to patch swarm-derive, for example the line below.

rust-libp2p/swarm-derive/src/lib.rs

Line 54 in 5cf6890

let protocols_handler = quote! {::libp2p::swarm::ConnectionHandler};

Hey @mxinden this seems straightforward enough, I created a PR. Lmk what you think.

maschad added a commit to maschad/rust-libp2p that referenced this issue May 16, 2022
@maschad
minor version bump to 0.27.2 (libp2p#2637)
7c96844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swarm/: Rename references of protocol handler to connection handler maschad/rust-libp2p
2 participants
@mxinden @maschad