Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: Deprecate futures::executor::ThreadPool usage for connection tasks #3107

Closed
thomaseizinger opened this issue Nov 10, 2022 · 1 comment · Fixed by #3588
Closed

swarm: Deprecate futures::executor::ThreadPool usage for connection tasks #3107

thomaseizinger opened this issue Nov 10, 2022 · 1 comment · Fixed by #3588
Labels
decision-pending Marks issues where a decision is pending before we can move forward. getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted priority:nicetohave

Comments

@thomaseizinger
Copy link
Contributor

Description

Currently, the default executor for connection tasks is a dedicated thread-pool created within the SwarmBuilder. With #3097, this is being made more explicit.

As a follow-up we should deprecate the use of ThreadPool entirely.

Motivation

Users of rust-libp2p will need to use some kind of async executor. They should use one of the new executor APIs introduced in #3097.

Are you planning to do it yourself in a pull request?

Maybe.
@thomaseizinger thomaseizinger added priority:nicetohave help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Nov 10, 2022
@thomaseizinger thomaseizinger mentioned this issue Nov 10, 2022
Merged
7 tasks
@thomaseizinger thomaseizinger added the decision-pending Marks issues where a decision is pending before we can move forward. label Nov 15, 2022
@dmitry-markin dmitry-markin mentioned this issue Dec 6, 2022
Merged
@thomaseizinger
Copy link
Contributor Author

@mxinden Are you in favor? I was going to action this as part of #3588.

@thomaseizinger thomaseizinger mentioned this issue Mar 13, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #3588 Mar 13, 2023
@mergify mergify bot closed this as completed in 2ec5402 Mar 13, 2023
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this issue Mar 8, 2024
@vnermolaev
feat(swarm): enforce creation of Swarm via SwarmBuilder
4a38e4c 
Mark constructors `Swarm::with_X_executor` as deprecated.
Move the deprecated functionality to `SwarmBuilder::with_X_executor`
Use `SwarmBuilder` throughout.

Resolves libp2p#3186.
Resolves libp2p#3107.

Pull-Request: libp2p#3588.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision-pending Marks issues where a decision is pending before we can move forward. getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(swarm): enforce creation of Swarm via SwarmBuilder vnermolaev/rust-libp2p
1 participant
@thomaseizinger