Debug instance for the gossipsub behaviour #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
reviewed
Jul 23, 2020
Since it is used only once here
Otherwise they might become very large and useless for debugging
tomaka
approved these changes
Jul 23, 2020
|
@rklaehn If you could update the gossipsub changelog and merge master, I can go ahead and merge this. |
mxinden
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To assist looking into #1671
Not sure if the nicer debug output is worth the extra dependency. For me it is, but YMMV. I can remove this if you see this differently.
Edit: I added truncation of the message bytes to ensure that the debug output for a gossipsub msg is not too big.