swarm: Add ExpandedSwarm::is_connected #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 335e55e removed the `ConnectionInfo` trait in favor of `PeerId`s. Commit 1bd013c removed `ExpandedSwarm::connection_info` as it would only return the `PeerId` that the caller is already aware of. One could use `ExpandedSwarm::connection_info` not only to retrieve the `ConnectionInfo` for a given peer, but also to check whether the underlying `Network` has a connection to the peer. This commit exposes the `is_connected` method on `Network` via `ExpandedSwarm` to check whether the `Network` has an established connection to a given peer.
romanb
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 335e55e removed the
ConnectionInfotrait in favor ofPeerIds. Commit1bd013c removed
ExpandedSwarm::connection_infoas it would only return thePeerIdthat the caller is already aware of.One could use
ExpandedSwarm::connection_infonot only to retrieve theConnectionInfofor a given peer, but also to check whether the underlyingNetworkhas a connection to the peer.This commit exposes the
is_connectedmethod onNetworkviaExpandedSwarmto check whether the
Networkhas an established connection to a given peer.One could as well expose other read-only methods on
Networklikeis_dialingand
is_disconnected. For now this pull request only restores the status-quo.Let me know what you prefer.