Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove throttled module #2236

Merged
merged 4 commits into from
Sep 25, 2021
Merged

Remove throttled module #2236

merged 4 commits into from
Sep 25, 2021

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Sep 17, 2021

Close #2196

Let me know whether I should bump the crate version or not.

thomaseizinger
thomaseizinger approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know whether I should bump the crate version or not.

Next version is already set to 0.13.0 due to other breaking changes so this is fine :)

One comment, otherwise LGTM!

protocols/request-response/CHANGELOG.md Outdated Show resolved Hide resolved
@tomaka @thomaseizinger
Update protocols/request-response/CHANGELOG.md
c6befc0 
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
mxinden
mxinden approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomaka.

For future readers, in case you would like to use the throttled feature, feel free to open up a pull request reintroducing the feature using a library with no licensing "conflict".

@mxinden mxinden merged commit f030b15 into libp2p:master Sep 25, 2021
@tomaka tomaka deleted the rm-throttled branch September 27, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor or remove request_response::throttled module because of licensing issues
3 participants
@tomaka @thomaseizinger @mxinden