Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: Fix rare test failure of multiple_addresses_err #2882

Merged
merged 6 commits into from
Sep 11, 2022

Conversation

thomaseizinger
Copy link
Contributor

Description

Fixes #2874.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] A changelog entry has been made in the appropriate crates

In case we accidentally generate the same port twice, we will try to
issue two dial attempts to the same address but also expect two dial
errors which is exactly what this test is trying to catch.
Unfortunately, the assertion is badly written and does not catch
duplicate inputs.
Not sure if it is just me, but I'd expect the expectation to come first.
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden
Copy link
Member

mxinden commented Sep 11, 2022

Ignoring testground failure due to libp2p/test-plans#41.

@mxinden mxinden merged commit 66c2755 into master Sep 11, 2022
@thomaseizinger thomaseizinger deleted the fix-multiple-address-test-failure branch September 19, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test swarm:multiple_addresses_err fails
2 participants