Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: Provide peer_id to inject_dial_failure on connection limit error #2928

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

dariusc93
Copy link
Member

@dariusc93 dariusc93 commented Sep 22, 2022

Description

This will fix the panic by providing the peer_id to inject_dial_failure

Links to any relevant issues

#2906

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dariusc93. Can you also bump the libp2p-swarm version in the root Cargo.toml and reference the version bump in the root Changelog.md?

@mxinden mxinden mentioned this pull request Sep 22, 2022
4 tasks
@dariusc93
Copy link
Member Author

Thank you @dariusc93. Can you also bump the libp2p-swarm version in the root Cargo.toml and reference the version bump in the root Changelog.md?

Went on and updated the root Cargo.toml and CHANGELOG.md

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one comment, otherwise LGTM!

swarm/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden
Copy link
Member

mxinden commented Sep 23, 2022

Interoperability tests failing due to libp2p/test-plans#41. Merging here.

@mxinden mxinden merged commit 121a11c into libp2p:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants