fix(swarm)!: make on_connection_handler_event impl mandatory. #3364
Conversation
There was a problem hiding this comment.
Can you expand the changelog entry of #3264 to say that this is now mandatory?
Yeah makes sense, updated! |
| Make the implementation of `on_swarm_event` and `on_connection_handler_event` | ||
| both mandatory. See [PR 3264] and [PR 3364]. |
There was a problem hiding this comment.
| Make the implementation of `on_swarm_event` and `on_connection_handler_event` | |
| both mandatory. See [PR 3264] and [PR 3364]. | |
| Make the implementation of `on_connection_handler_event` | |
| mandatory and thus consistent with `on_swarm_event`. See [PR 3264] and [PR 3364]. |
I find the wording hard to understand, i.e. I would expect this change to touch both methods, whereas in reality it doesn't.
There was a problem hiding this comment.
sorry for the confusion introduced Max. It does, it's just that for on_connection_handler_event it was left out on #3264. Does the CHANGELOG entry make more sense to you, or do you still want me to adress it?
There was a problem hiding this comment.
Ah, right, my bad. Thanks for clarifying.
| Make the implementation of `on_swarm_event` and `on_connection_handler_event` | ||
| both mandatory. See [PR 3264] and [PR 3364]. |
There was a problem hiding this comment.
Ah, right, my bad. Thanks for clarifying.
|
This pull request has merge conflicts. Could you please resolve them @jxs? 🙏 |
Description
Sorry I missed this on #3264
Notes
Links to any relevant issues
Open Questions
Change checklist