feat: don't report inbound stream upgrade errors to handler #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mxinden
reviewed
Mar 14, 2023
thomaseizinger
commented
Mar 14, 2023
|
@thomaseizinger let me know if you want another review here. |
Go for it. It is only a draft because it is a breaking change. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…-libp2p into feat/no-report-inbound-error
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mxinden
previously approved these changes
May 4, 2023
| })); | ||
| } | ||
| } | ||
| self.pending_error = Some(ConnectionHandlerUpgrErr::Upgrade(UpgradeError::Apply( |
There was a problem hiding this comment.
I think we are on the same page when I say that libp2p-relay should not be closing the connection based on pending_error via ConnectionHandlerEvent::Close further below in poll. That said, let's not fix it here but along with #3591.
There was a problem hiding this comment.
Yes, it should be a much easier change once this lands too!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4 tasks
mxinden
approved these changes
May 8, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an inbound stream upgrade fails, there isn't a whole lot we can do about that in the handler. In fact, for several errors, we wouldn't even know which specific handler to target, for example,
NegotiationFailed. Similiarly, in case of an IO error during the upgrade, we don't know which handler the stream was eventually meant to be for.Notes & open questions
This is a breaking change, thus draft for now.Change checklist