Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relay): ensure stable connect test #3780

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix(relay): ensure stable connect test #3780

merged 2 commits into from
Apr 12, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

With the changes from #3767, we made the connect test flaky because the Swarm was fully passed to the future and thus dropped as soon as the connection was established. We pass a mutable reference instead which keeps the Swarm alive.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify mergify bot merged commit 9eb3030 into master Apr 12, 2023
@mergify mergify bot deleted the fix/relay-flaky-test branch April 12, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants