feat(swarm): add ConnectionDenied::downcast_ref
#4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc/connection-limits/src/lib.rs
Outdated
| @@ -466,6 +466,57 @@ mod tests { | |||
| quickcheck(prop as fn(_)); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn max_established_incoming_downcast_ref() { | |||
There was a problem hiding this comment.
I don't think we need this test. We don't actually control any logic here other than forwarding calls so the typesystem should be good enough :)
There was a problem hiding this comment.
Should I remove the test or just leave it be?
thomaseizinger
changed the title
ConnectionDenied::downcast_ref
|
This pull request has merge conflicts. Could you please resolve them @nathanielc? 🙏 |
Prior to this change it was possible to only have a reference to a ConnectionDenied error and not be able to downcast it to check if the connection-limits produced the error.
|
@thomaseizinger Thanks for the review, I have fixed the conflicts, added a changelog entry and removed the unnecessary test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change it was only possible to downcast a
ConnectionDeniederror when you had ownership of it which isn't the case insideNetworkBehaviours. This change allows downcasting by reference.See #4018.
Change checklist