Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swarm): external address candidate only after address translation #4158

Merged
merged 3 commits into from
Jul 9, 2023
Merged

fix(swarm): external address candidate only after address translation #4158

merged 3 commits into from
Jul 9, 2023

Commits on Jul 6, 2023

  1. swarm: translate external address candidate 

    The `NewExternalAddrCandidate` event is yielded both before and after address translation. This will
cause, in the case of TCP, ephemeral ports to be added as candidate.

In turn, that will cause protocols like AutoNAT to fail as these candidates are not actually
reachable/external.

We will now only yield the original candidate if translation did not apply.

Fixes libp2p#4153
    @b-zee
    b-zee committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    a18677f View commit details
    Browse the repository at this point in the history

  2. chore: bump patch for swarm; CHANGELOG entry

    @b-zee
    b-zee committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    21338e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Merge branch 'master' into fix-swarm-addr-candidate

    @mergify
    mergify[bot] committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    329f3a4 View commit details
    Browse the repository at this point in the history