fix(server): remove support_draft_29
#4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for QUIC draft 29 was removed with libp2p#4467. libp2p#4120 reintroduced it as a faulty merge. This commit removes it again.
mxinden
added
send-it
trivial
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for QUIC draft 29 was removed with #4467.
#4120 reintroduced it as a faulty merge.
This commit removes it again.
Notes & open questions
My bad. I am sorry for the trouble.
@mcamou thank you for bringing this to the surface.
@thomaseizinger merging here as is. Happy to do follow-ups. For context, @mcamou saw our rust-libp2p IPFS staging server fail with
Address already in use.Change checklist