feat(gossipsub): remove KeepAlive::Until
#4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Let us know once this is ready for review. Generally in favor of removing the idle timeout from |
leonzchang
changed the title
KeepAlive::Until usage from libp2p-gossipsubKeepAlive::Until usage from gossipsub
|
@mxinden I would be deeply grateful for your feedback |
thomaseizinger
changed the title
KeepAlive::Until usage from gossipsubKeepAlive::Until usage from gossipsub
thomaseizinger
changed the title
KeepAlive::Until usage from gossipsubKeepAlive::Until usage
thomaseizinger
changed the title
KeepAlive::Until usageKeepAlive::Until
|
If this PR is okay, I'll move on to the rest protocols. |
thomaseizinger
previously approved these changes
Oct 14, 2023
|
FYI: We set all PRs that are queued for the next breaking change to draft to avoid accidentally merging them. |
Looks good to me, thank you! |
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏 |
mergify
bot
dismissed
thomaseizinger’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
|
This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏 |
thomaseizinger
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #3844.
Notes & open questions
Change checklist