chore(perf): remove unused module

[leonzchang]

Description

Related: #3844.

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[leonzchang]

Since this PR doesn't change any public API, I think bump the patch version will be ok?

[thomaseizinger]

Thanks for sending this!

I just had a look at the code and we seem to have a duplicate implementation here? Everything in client/ and server/ is actually unused. My IDE flags the modules as not included in the module tree.

Thus I think what you can do is simply delete these directories :)
Because the code is not included, we don't even need to bump version here.

[leonzchang]

Thanks for sending this!

I just had a look at the code and we seem to have a duplicate implementation here? Everything in client/ and server/ is actually unused. My IDE flags the modules as not included in the module tree.

Thus I think what you can do is simply delete these directories :) Because the code is not included, we don't even need to bump version here.

Ok, fixed b77234f, will move on to the rest protocols

[thomaseizinger]

Always great to delete code! :)

Thanks!

[thomaseizinger]

cc @mxinden This seems to have been an oversight when you refactored it to use libp2p-request-response! I am not sure how close #4382 is to be mergable but if that needs any of this code again, it can always just re-introduce it.

For now, deleting this allows us to make progress on #3844.

[thomaseizinger]

Hmm, this new changelog lint that I introduced does have some funny side-effects in regards to non-changelog-worthy changes like this one.

[thomaseizinger]

Hmm, this new changelog lint that I introduced does have some funny side-effects in regards to non-changelog-worthy changes like this one.

Okay, I have a temporary fix in #4658.

[mxinden]

Thank you for the clean-up @leonzchang!

@thomaseizinger agreed, don't need to wait for #4382.