Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swarm): remove KeepAlive::Until from OneshotHandler #4677

Merged
merged 7 commits into from
Oct 20, 2023
Merged

feat(swarm): remove KeepAlive::Until from OneshotHandler #4677

merged 7 commits into from
Oct 20, 2023

Conversation

leonzchang
Copy link
Contributor

Description

Related: #3844.
Related: #4656.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang marked this pull request as ready for review October 17, 2023 08:55
thomaseizinger
thomaseizinger reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Just one comment.

swarm/src/handler/one_shot.rs Show resolved Hide resolved
@thomaseizinger thomaseizinger marked this pull request as draft October 17, 2023 09:22
@thomaseizinger thomaseizinger changed the title feat(one-shot): remove KeepAlive::Until feat(swarm): remove KeepAlive::Until from OneshotHandler` Oct 17, 2023
@thomaseizinger thomaseizinger changed the title feat(swarm): remove KeepAlive::Until from OneshotHandler` feat(swarm): remove KeepAlive::Until from OneshotHandler Oct 17, 2023
@thomaseizinger thomaseizinger mentioned this pull request Oct 17, 2023
Closed
@leonzchang leonzchang mentioned this pull request Oct 17, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@leonzchang
feat(swarm): deprecated keep_alive_timeout from OneShotHandlerConfig
203e11c 
Related: #3844.
Related: #4677

Pull-Request: #4680.
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Oct 17, 2023
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger marked this pull request as ready for review October 20, 2023 01:18
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏

thomaseizinger
thomaseizinger reviewed Oct 20, 2023
View reviewed changes
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot merged commit b1b46d1 into libp2p:master Oct 20, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leonzchang @thomaseizinger