Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump yamux from 0.12.0 to 0.12.1 #4930

Merged
merged 4 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions muxers/yamux/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 0.45.1
Copy link
Contributor

@thomaseizinger thomaseizinger Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxinden You forgot to bump the version in Cargo.toml for this. CI didn't catch it because this check is disabled for dependency upgrades as we don't want to bump the version for dependencies by default.


- Deprecate `WindowUpdateMode::on_receive`.
It does not enforce flow-control, i.e. breaks backpressure.
Use `WindowUpdateMode::on_read` instead.
See `yamux` crate version `v0.12.1` and [Yamux PR #177](https://github.com/libp2p/rust-yamux/pull/177).

## 0.45.0

- Migrate to `{In,Out}boundConnectionUpgrade` traits.
Expand Down
2 changes: 2 additions & 0 deletions muxers/yamux/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,9 @@ impl WindowUpdateMode {
/// > size must be tuned appropriately for the desired
/// > throughput and level of tolerance for (temporarily)
/// > slow receivers.
#[deprecated(note = "Use `WindowUpdateMode::on_read` instead.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of having the entire WindowUpdateMode struct if it has only one option? Shouldn't it be deprecated entirely?

pub fn on_receive() -> Self {
#[allow(deprecated)]
WindowUpdateMode(yamux::WindowUpdateMode::OnReceive)
}

Expand Down