Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: move libp2p-server and metrics example to use axum 0.7 #5246

Merged
merged 14 commits into from
Apr 11, 2024
Merged

deps: move libp2p-server and metrics example to use axum 0.7 #5246

merged 14 commits into from
Apr 11, 2024

Conversation

drHuangMHT
Copy link
Contributor

@drHuangMHT drHuangMHT commented Mar 19, 2024 •
edited
Loading

Description

Move from hyper to axum for libp2p-server and metrics example.
Running in parallel with #5038.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@jxs
Copy link
Member

jxs commented Mar 21, 2024

Hi @drHuangMHT did you see #5038?

@drHuangMHT
Copy link
Contributor Author

Hi @drHuangMHT did you see #5038?

Oopsie, didn't see that.

@drHuangMHT drHuangMHT changed the title deps: (PoC)Bump hyper to 1.1.0 deps: (PoC)Move libp2p-server and metrics example to use axum 0.7 Apr 1, 2024
@drHuangMHT
Copy link
Contributor Author

drHuangMHT commented Apr 1, 2024 •
edited by jxs
Loading

Following #5038 (comment) updated the code.
probably should have opened a new PR.... Ping @jxs how do you feel?

jxs
jxs approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Very nice work, LGTM!
(no worries regarding using this PR, I updated your comment to address the context, hope you don't mind)
CC @thomaseizinger since you started this

examples/metrics/src/http_service.rs Show resolved Hide resolved
@jxs jxs changed the title deps: (PoC)Move libp2p-server and metrics example to use axum 0.7 deps: move libp2p-server and metrics example to use axum 0.7 Apr 1, 2024
@drHuangMHT
Copy link
Contributor Author

Ping @thomaseizinger Got a minute to review this PR?

thomaseizinger
thomaseizinger approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass, nothing blocking.

examples/metrics/src/http_service.rs Outdated Show resolved Hide resolved
examples/metrics/src/http_service.rs Outdated Show resolved Hide resolved
examples/metrics/src/http_service.rs Outdated Show resolved Hide resolved
examples/metrics/src/http_service.rs Outdated Show resolved Hide resolved
misc/server/src/http_service.rs Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

Can you solve the merge conflicts?

@drHuangMHT
Copy link
Contributor Author

Can you solve the merge conflicts?

Done. Staging this PR?

@thomaseizinger thomaseizinger marked this pull request as ready for review April 9, 2024 07:30
thomaseizinger
thomaseizinger previously approved these changes Apr 9, 2024
View reviewed changes
jxs
jxs previously approved these changes Apr 11, 2024
View reviewed changes
@jxs jxs added the send-it label Apr 11, 2024
@jxs
Copy link
Member

jxs commented Apr 11, 2024

Thanks @drHuangMHT ❤️ and Thomas for the review

@mergify mergify bot dismissed thomaseizinger’s stale review April 11, 2024 15:52

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot dismissed jxs’s stale review April 11, 2024 15:52

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 042174e into libp2p:master Apr 11, 2024
71 of 72 checks passed
@drHuangMHT drHuangMHT deleted the hyper-bump branch April 22, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@jxs jxs jxs left review comments

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drHuangMHT @jxs @thomaseizinger