Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relay): use web_time Instant and SystemTime versions for wasm support. #5328

Merged
merged 10 commits into from
Apr 30, 2024

Conversation

dariusc93
Copy link
Member

Description

Resolves #5305.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Darius! Can we rather introduce web-time here (see sebcrozet/instant#52) and then replace instant on the rest of the project on a subsequent PR?

@dariusc93
Copy link
Member Author

Thanks for this Darius! Can we rather introduce web-time here (see sebcrozet/instant#52) and then replace instant on the rest of the project on a subsequent PR?

That is fine with me (I was planning on doing that in a separate PR)

@dariusc93 dariusc93 requested a review from jxs April 29, 2024 23:31
@jxs jxs changed the title fix: use instant variant of SystemTime for wasm support. fix(relay): use web_time Instant and SystemTime versions for wasm support. Apr 30, 2024
protocols/relay/CHANGELOG.md Outdated Show resolved Hide resolved
@jxs jxs added the send-it label Apr 30, 2024
@mergify mergify bot merged commit e5c072c into libp2p:master Apr 30, 2024
70 of 72 checks passed
@dariusc93
Copy link
Member Author

Thanks for merging. Is it possible to get a patch release for this @jxs?

@jxs
Copy link
Member

jxs commented Apr 30, 2024

Thanks for this Darius! Yeah there are also some minor releases pending, I'll try to do that Today

@jxs
Copy link
Member

jxs commented May 1, 2024

published new libp2p-relay minor @dariusc93, see #5351 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relay: panics due to unimplemented time in wasm
2 participants