Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ConnectionError to FromSwarm::ConnectionClosed #5485

Merged
merged 8 commits into from
Jul 9, 2024
Merged

feat: Add ConnectionError to FromSwarm::ConnectionClosed #5485

merged 8 commits into from
Jul 9, 2024

Conversation

dariusc93
Copy link
Member

@dariusc93 dariusc93 commented Jul 7, 2024 •
edited
Loading

Description

Resolves #5484.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dariusc93 dariusc93 changed the title feat: report ConnectionError to FromSwarm::ConnectionClosed feat: Add ConnectionError to FromSwarm::ConnectionClosed Jul 8, 2024
jxs
jxs approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Darius, is this ready for merge? I am wrapping up for the 0.54 release

@dariusc93
Copy link
Member Author

LGTM Darius, is this ready for merge? I am wrapping up for the 0.54 release

Yes it's ready

@jxs jxs added the send-it label Jul 9, 2024
@jxs jxs added this to the v0.54.0 milestone Jul 9, 2024
@jxs jxs marked this pull request as ready for review July 9, 2024 17:40
@mergify mergify bot merged commit 02fa7c8 into libp2p:master Jul 9, 2024
72 checks passed
TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this pull request Sep 14, 2024
@dariusc93 @TimTinkers
feat: Add ConnectionError to FromSwarm::ConnectionClosed
6abdfc7 
Resolves libp2p#5484.

Pull-Request: libp2p#5485.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.

swarm: Add ConnectionError to FromSwarm::ConnectionClosed
2 participants
@dariusc93 @jxs