Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove library extractor #18

Closed
wants to merge 2 commits into from
Closed

Remove library extractor #18

wants to merge 2 commits into from

Conversation

timyhac
Copy link
Collaborator

@timyhac timyhac commented Jul 4, 2020

This still doesn't work for dotnet framework out of the box. But it does work for dotnet core projects.

@timyhac timyhac requested a review from jkoplo July 4, 2020 01:50
@timyhac
Copy link
Collaborator Author

timyhac commented Jul 5, 2020

Holy moly - I've been down rabbit-hole again around how to support both dotnet core and dotnet framework in a nuget package and its still not good news. NuGet/Home#6645

I don't think we should remove this library extraction stuff at the moment as it still seems the most straightforward way of doing it, but I do think we should look into why it doesn't work for Framework projects.

One benefit of doing the library extraction in code is that the user doesn't have to target x86 or x64, they can leave As AnyCPU and the wrapper will take care of extracting the appropriate runtime.

@timyhac timyhac closed this Jul 5, 2020
@kyle-github
Copy link
Member

Wow. That's... quite a read. I think I understood about one word in five on that NuGet issue.

I really need to solve the same issue with Java and now I am really not looking forward to it at all!

@timyhac
Copy link
Collaborator Author

timyhac commented Jul 5, 2020 via email

@jkoplo jkoplo deleted the remove-library-extractor branch July 9, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants