Allow Mapper to Configure Tag prior to initialization #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where do we stand on this? I don't think we came to a firm conclusion in #211. |
|
I haven't yet done any of the investigation I said I would do.. |
|
Do you think we could cut a stable/beta release (1.1.0 with #93) and get this into a later release? |
timyhac
commented
Oct 8, 2022
| @@ -72,6 +72,11 @@ virtual protected void EncodeArray(Tag tag, T[] values) | |||
| T[,,] IPlcMapper<T[,,]>.Decode(Tag tag) => DecodeArray(tag).To3DArray<T>(ArrayDimensions[0], ArrayDimensions[1], ArrayDimensions[2]); | |||
|
|
|||
| void IPlcMapper<T[,,]>.Encode(Tag tag, T[,,] value) => EncodeArray(tag, value.To1DArray()); | |||
|
|
|||
| public void Configure(Tag tag) | |||
There was a problem hiding this comment.
Shouldn't this be virtual so we can override it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change since it requires IPlcMapper implementations to implement a new method.
As such it will need to go into a 2.x release