-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL data types need to be refactored #13
Comments
Sorry for the late reply, I've been held up by work lately. I agree that the data types aren't quite accurate, but I'm not really sure that I'd want to implement this change now, because:
I'll leave it open for now, but implementing this change is very unlikely in the near future. Maybe in v2? |
Ping and co generates numerical data by nature. Using numerical data allows the LibreSpeed database to be treated as a time series database without any additional coding. |
Yes, I understand, but in the code: speedtest-go/database/mysql/mysql.go Lines 30 to 46 in c815103
... fields in |
This might be fixed with a migration: the code can detect this change at runtime and ask the user to migrate (or automatically migrate) |
dl
,ul
,ping
,jitter
are numbers, not a text,text
andlongtext
are too big data types,Environment
Links
The text was updated successfully, but these errors were encountered: