Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning for Rodio on Alsa (fixed upstream) #696

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

roderickvd
Copy link
Member

Fixed with the recent bump of the Rodio and cpal crates.

@roderickvd
Copy link
Member Author

The build is fine but the CI is failing over some Spotify server error. Please rerun the tests or just ignore the results.

@Johannesd3
Copy link
Contributor

Is the Cargo.lock already up to date?

I can't observe any CI failure, BTW

@roderickvd
Copy link
Member Author

Is the Cargo.lock already up to date?

Yes, this was merged in 222f9bb.

I can't observe any CI failure, BTW

Neither do I, they must have run again.

@ashthespy ashthespy merged commit 7226bfd into librespot-org:dev Apr 15, 2021
@roderickvd roderickvd deleted the remove-rodio-warning branch April 15, 2021 06:48
@Johannesd3
Copy link
Contributor

I added this test that tries to connect to the Spotify servers using the credentials test - test end expects an error "Bad credentials", but every now and then it fails... Recently, it even hung up. Maybe this test was a stupid idea.

roderickvd added a commit to roderickvd/librespot that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants