Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first batch of simplifications #435

Merged
merged 2 commits into from
Oct 29, 2019
Merged

first batch of simplifications #435

merged 2 commits into from
Oct 29, 2019

Conversation

minad
Copy link
Member

@minad minad commented Oct 29, 2019

@sjaeckel I extracted a few of the very trivial ones from #434.

@minad minad requested a review from sjaeckel October 29, 2019 18:04
@minad minad force-pushed the simple-simplifications branch 2 times, most recently from 3fba991 to f9f27b8 Compare October 29, 2019 18:18
@minad minad added the finished label Oct 29, 2019
@minad minad mentioned this pull request Oct 29, 2019
Copy link
Contributor

@czurnieden czurnieden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normally don't "self select as a reviewer" but this deserved a bit more than just a simple thumbs-up emoji.

@minad
Copy link
Member Author

minad commented Oct 29, 2019

@czurnieden I am looking forward to you reviewing the more complex functions and simplifying mp_prime_strong_lucas_selfridge, s_mp_exptmod, s_mp_exptmod_fast 😈

See #434

Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks a lot

@sjaeckel sjaeckel merged commit 820f4bb into develop Oct 29, 2019
@sjaeckel sjaeckel deleted the simple-simplifications branch October 29, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants