Skip to content

Commit

Permalink
lnrpc: avoid needing to download Golang
Browse files Browse the repository at this point in the history
Because the Go version used to run the `go list` commands is below the
minimum version specified in the main go.mod file, every time the `make
rpc` command is executed, the Golang runtime is downloaded twice, which
looks like this and takes a couple of seconds at least:

go: downloading go1.21.4 (linux/amd64)
go: downloading go1.21.4 (linux/amd64)

We fix this by using the correct minimum version.
  • Loading branch information
guggero committed Aug 6, 2024
1 parent ab96de3 commit 63af63d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lnrpc/gen_protos_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -e
DIR="$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)"

# golang docker image version used in this script.
GO_IMAGE=docker.io/library/golang:1.21.0-alpine
GO_IMAGE=docker.io/library/golang:1.21.4-alpine

PROTOBUF_VERSION=$(docker run --rm -v $DIR/../:/lnd -w /lnd $GO_IMAGE \
go list -f '{{.Version}}' -m google.golang.org/protobuf)
Expand Down

0 comments on commit 63af63d

Please sign in to comment.