[autopilot] Trigger channel opening on external score update #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
autopilot-heuristic-update-trigger
branch
2 times, most recently
from
a32705d
to
a2257f9
Compare
Roasbeef
requested changes
Oct 9, 2019
carlaKC
reviewed
Oct 9, 2019
halseth
force-pushed
the
autopilot-heuristic-update-trigger
branch
from
a2257f9
to
765b2ee
Compare
|
Unit test added. |
When appending to a slice, there is no guarantee the slice won't be modified. So instead of appending to the global slice availableHeuristics, we create a temporary local one.
This commit adds a new signal to the autopilot agent, meant to signal when any of the available heuristics has gotten an update. We currently use this to trigger a new channel opening after the external scores have been updated.
TestAgentHeuristicUpdateSignal tests that upon notification about a heuristic update, the agent reconsults the heuristic.
halseth
force-pushed
the
autopilot-heuristic-update-trigger
branch
from
765b2ee
to
5a8ecfc
Compare
carlaKC
approved these changes
Oct 31, 2019
| @@ -372,5 +379,11 @@ func (m *Manager) SetNodeScores(name string, scores map[NodeID]float64) error { | |||
| return fmt.Errorf("heuristic with name %v not found", name) | |||
| } | |||
|
|
|||
| // If the autopilot agent is active, notify about the updated | |||
| // heuristic. | |||
| if m.pilot != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new signal to the autopilot agent, meant to signal
when any of the available heuristics has gotten an update.
We currently use this to trigger a new channel opening after the
external scores have been updated.