routerrpc: add queryprob rpc #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2019
joostjager
force-pushed
the
query-mc-prob
branch
2 times, most recently
from
b1e9859
to
9ec1007
Compare
Roasbeef
added
enhancement
joostjager
force-pushed
the
query-mc-prob
branch
4 times, most recently
from
2ea9411
to
8644ceb
Compare
carlaKC
approved these changes
Oct 25, 2019
halseth
reviewed
Oct 29, 2019
| @@ -125,7 +125,24 @@ type timedPairResult struct { | |||
| // timestamp is the time when this result was obtained. | |||
| timestamp time.Time | |||
|
|
|||
| pairResult | |||
There was a problem hiding this comment.
now that these field are replicated both here and in pairResult, can this struct type be removed now?
| } | ||
|
|
||
| if !data.Timestamp.IsZero() { | ||
| rpcData.Timestamp = data.Timestamp.Unix() |
There was a problem hiding this comment.
why don't do Unix() also when zero?
There was a problem hiding this comment.
It is a very negative number. The beginning of time.Time is far before 1970.
| double probability = 1 [json_name = "probability"]; | ||
|
|
||
| /// The historical data for the requested pair. | ||
| PairData history = 2 [json_name = "history"]; |
There was a problem hiding this comment.
is the reason for PairData to reuse it here?
joostjager
force-pushed
the
query-mc-prob
branch
from
8644ceb
to
73eba92
Compare
This prepares for decoupling the result interpretation of a single payment attempt from the information stored in mission control memory on the history of a node pair. A planned follow-up where we store both the last success and last failure requires this decoupling.
Prepares for this data structure being accessed in mission control rpc implementations.
With a separate proto message, it becomes possible to also return the pair data for a single pair. This prepares for the new mc probability querying rpc.
Probabilities are no longer returned for querymc calls. To still provide some insight into the mission control internals, this commit adds a new rpc that calculates a success probability estimate for a specific node pair and amount.
joostjager
force-pushed
the
query-mc-prob
branch
from
73eba92
to
fb57255
Compare
halseth
approved these changes
Oct 29, 2019
joostjager
changed the title
carlaKC
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3462, we removed probability reporting for
querymc. This PR brings it back as a separate rpc for which a specific amount needs to be given.In addition to the probability, it also returns the raw data for the requested pair. An example use case for this is to get a sense for the freshness of a pair and use this to decide whether to do a prepay probe for a route.