Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase block size to 200 gigamegs! #3730

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Nov 15, 2019

This PR increases the gRPC max receive size again, this time from 50MiB to 200MiB.
The operation that hits the maximum is lncli listchaintxns with about 2.6k transactions on testnet (see lightninglabs/lndmon#48).
As mentioned in #2374, this only affects lncli, users of the gRPC API need to set this value on the client side.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

We may also need to raise the settings on the REST side to allow the clients to receive this data up to this size.

@Roasbeef Roasbeef merged commit cea2429 into lightningnetwork:master Nov 15, 2019
@guggero guggero deleted the grpc-receive-size branch November 16, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants