lnwire: assert sorted short channel ids #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
force-pushed
the
in-order-sids
branch
from
06b9628
to
2a6e412
Compare
wpaulino
approved these changes
Nov 27, 2019
halseth
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies our decoding of short channel id arrays to also assert that the decoded ids are in order for the plain encodings. We already do so for the zlib encoding, though this isn't tested directly. Here we correct the decoding make this assertion for plain encodings, and add unit tests to both
QueryShortChanIDsandReplyChannelRangeto ensure that they fail with this error when presented with duplicate or unsorted channel ids for either plain or zlib.