channeldb: inject clock into database #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
requested review from
cfromknecht,
halseth,
Roasbeef and
wpaulino
as code owners
joostjager
changed the title
cfromknecht
reviewed
Dec 5, 2019
channeldb/db.go
Outdated
| @@ -142,7 +142,9 @@ type DB struct { | |||
|
|
|||
| // Open opens an existing channeldb. Any necessary schemas migrations due to | |||
| // updates will take place as necessary. | |||
| func Open(dbPath string, modifiers ...OptionModifier) (*DB, error) { | |||
| func Open(dbPath string, now func() time.Time, modifiers ...OptionModifier) ( | |||
There was a problem hiding this comment.
why not set time.Now as the default in DefaultOptions(), then add a functional modifier? much smaller diff
There was a problem hiding this comment.
Great suggestion, done
|
Just saw this. Now that we have clock.Clock you might as well use that instead of the now closure. |
Roasbeef
added
code health
joostjager
force-pushed
the
explicit-now-dependency-channeldb
branch
from
d484505
to
9b9721a
Compare
joostjager
changed the title
joostjager
removed
the
incomplete
joostjager
changed the title
Use our standard clock mock for database time queries.
joostjager
force-pushed
the
explicit-now-dependency-channeldb
branch
from
9b9721a
to
b600ecd
Compare
cfromknecht
reviewed
Jan 22, 2020
cfromknecht
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a leftover of the mpp invoice registry pr #3415. There we took a shortcut to expose
Nowas a public field on the database in order to unblock the stack of dependent prs. This is now converted to a properclock.Clockdependency.