[anchors] Pluggable anchor commitments #3798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We define a new type CommitmentType, that abstracts away how keys are generated for the different commitment types (currently tweak(less)). Intention is that more of the logic that is unique for each commitment type is behind the type, making the channel state machine oblivious to the keys and outputs being created on the commitment tx for a given channel state.
To make the channel state machine less concerned about the type of commitment, we nil the local tweak when creating the keyring, depending on the commitment type.
It was incorrectly stated that the commitment balance was before subctracting the commit fee, which led to some confusion.
Instead of passing delays and dustlimits separately, we pass the correct channel config to CreateCommitTx from the POV of the local party that owns the commit tx. To make it more clear which commitment we are actually creating, we rename variables to denote local and remote, to prepare for the case when both outputs might be delayed.
Since both parties are going to have their ouputs delayed, we move way from the DelayKey naming, and instead use LocalKey and RemoteKey.
Based on the current commitment type, we derive the script used for the to_remote output.
With this commitment type, we'll add extra achnor outputs to the commitment transaction.
Based on the commitment type, the commitment weight will be calculated.
halseth
force-pushed
the
pluggable-anchor
branch
from
3647171
to
9889e69
Compare
joostjager
reviewed
Dec 5, 2019
| @@ -747,24 +753,24 @@ func (l *LightningWallet) handleFundingCancelRequest(req *fundingReserveCancelMs | |||
| // initial funding workflow as both sides must generate a signature for the | |||
| // remote party's commitment transaction, and verify the signature for their | |||
| // version of the commitment transaction. | |||
| func CreateCommitmentTxns(localBalance, remoteBalance btcutil.Amount, | |||
| func CreateCommitmentTxns(localBalance, remoteBalance, | |||
There was a problem hiding this comment.
Shouldn't this complete function be moved into the plugin?
| // commitment type. | ||
| type CommitmentType struct { | ||
| chanType channeldb.ChannelType | ||
| } |
There was a problem hiding this comment.
I actually expected an interface here with three implementations?
| @@ -331,7 +332,8 @@ func (c *chainWatcher) SubscribeChannelEvents() *ChainEventSubscription { | |||
| // based off of only the set of outputs included. | |||
| func isOurCommitment(localChanCfg, remoteChanCfg channeldb.ChannelConfig, | |||
There was a problem hiding this comment.
Shouldn't this be a method on CommitmentType too?
lnwallet/channel.go
Outdated
| @@ -2375,7 +2304,7 @@ func (lc *LightningChannel) fundingTxIn() wire.TxIn { | |||
| // createCommitmentTx generates the unsigned commitment transaction for a | |||
| // commitment view and assigns to txn field. | |||
| func (lc *LightningChannel) createCommitmentTx(c *commitment, | |||
There was a problem hiding this comment.
Not a method on the plugin?
|
Replaced by #3821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.