routing: penalize node-level failures harder #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only penalized the outgoing connections of a failing node. This turned out not to be sufficient, because the next route sometimes went into the same failing node again to try a different outgoing connection that wasn't yet known to mission control and therefore not penalized before.
joostjager
force-pushed
the
node-level-penalty
branch
from
c6025d4
to
ef28d2a
Compare
joostjager
requested review from
cfromknecht and
halseth
and removed request for
Roasbeef
halseth
reviewed
Jan 21, 2020
| // reverse the pair. We don't want to affect the score of the node | ||
| // sending towards the failing node. | ||
| // getPair is penalized in the original and the reversed direction. Note | ||
| // that this will also affect the score of the failing node's peers. |
There was a problem hiding this comment.
So node A can impact the score of node B by just not forwarding payments to it?
There was a problem hiding this comment.
Yes, that's true. You become less popular if you have bad friends. But this mainly affects A's link to B specifically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only penalized the outgoing connections of a failing node. This turned out not to be sufficient, because the next route sometimes went into the same failing node again to try a different outgoing connection that wasn't yet known to mission control and therefore not penalized before.