-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
channeldb: Indicate cooperative close initator #3961
Merged
halseth
merged 8 commits into
lightningnetwork:master
from
carlaKC:3709-cooperativecloseinitiator
Feb 21, 2020
Merged
channeldb: Indicate cooperative close initator #3961
halseth
merged 8 commits into
lightningnetwork:master
from
carlaKC:3709-cooperativecloseinitiator
Feb 21, 2020
Commits on Feb 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8d632b8 - Browse repository at this point
Copy the full SHA 8d632b8View commit details -
channeldb: store close initiator status
This commit adds two new channel statuses which indicate the party that initatited closing the channel. These statuses are set in conjunction with the existing commit broadcast status so that we do not need to migrate existing logic to handle multiple types of closes. This status is set for locally initiated force closes in this commit because they follow a similar pattern to cooparative closes, marking the commitment broadcast then proceeding with tx broadcast. Remote force closes are added in the following commit, as they are handled differently.
Configuration menu - View commit details
-
Copy full SHA for d3cb6ad - Browse repository at this point
Copy the full SHA d3cb6adView commit details -
channeldb: save channel status on channel close
Add an optional channel status CloseChannel which will be stored on the hitsorical channel which is persisted at channel close. This status is used to set the close initiator for channels that do not complete the funding flow or we abandon. In follow up commits, this status will be used to record force and breach closes. The value is written to the historical channel bucket for diplay over rpc.
Configuration menu - View commit details
-
Copy full SHA for 11d975b - Browse repository at this point
Copy the full SHA 11d975bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9915e0 - Browse repository at this point
Copy the full SHA c9915e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eb3036 - Browse repository at this point
Copy the full SHA 4eb3036View commit details -
lnrpc: add open and close initiator to close summary
Add an initiator enum which allows up to display an unknown value for channels that are not in the historical chan bucket, rather than having and ambiguous false value also representing no-value. A both option is added to cover the case where both parties initiated a close on chain.
Configuration menu - View commit details
-
Copy full SHA for b55470e - Browse repository at this point
Copy the full SHA b55470eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e74b6f8 - Browse repository at this point
Copy the full SHA e74b6f8View commit details -
lntest: check close initiator in basic channel itest
Update channel updates and subscription itest to check that close initiator is appropriately set for cooperative and force closes for the local and remote party.
Configuration menu - View commit details
-
Copy full SHA for b3e6395 - Browse repository at this point
Copy the full SHA b3e6395View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.