Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: instruct REST marshaler to emit default values #3965

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Jan 27, 2020

This change instructs the REST proxy server to overwrite its default
JSON marshaler settings. That allows us to set EmitDefaults to true
which will result in all JSON fields returned in REST responses to
be fully populated, even if their values are falsey.

Fixes #2087.

This change instructs the REST proxy server to overwrite its default
JSON marshaler settings. That allows us to set EmitDefaults to true
which will result in all JSON fields returned in REST responses to
be fully populated, even if their values are falsey.
@Roasbeef Roasbeef added this to the 0.9.1 milestone Jan 27, 2020
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌊

@Roasbeef Roasbeef merged commit 04c3998 into lightningnetwork:master Jan 27, 2020
@guggero guggero deleted the rest-api-falsey branch January 28, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API responses missing falsey values
2 participants