-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: support config bitcoind fee estimate mode #4078
multi: support config bitcoind fee estimate mode #4078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks pretty good!
047fe8f
to
1f5ae8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just two style nits from me, non-blocking :)
1f5ae8c
to
866cc72
Compare
866cc72
to
83ac1a8
Compare
83ac1a8
to
97da7b3
Compare
Alternatively, we could also extend any RPCs that already require fee-related parameters with the estimate mode instead of having the config option. Though I think the two can still go together, as the config option will be used as the default, and you can express your preference differently through the RPC if necessary. Extending the RPCs would be out of scope for this PR of course. Thoughts @yyforyongyu? |
Since it would require the user to restart lnd if changing the estimate mode is needed, yes, it would be better if we could also provide the option in related RPCs. Atm, I believe there are However, I think it won't be done without a drawback. Specifically, |
Good point, we could return an error when using it with other backends. It's not something we need to worry about for this PR though. |
This PR fixes issue #2990
Pull Request Checklist
Contribution Guidelines
the positive and negative (error paths) conditions (if applicable)
the bug being fixed to prevent regressions
logging level
go fmt
lnrpc/**/*.proto
) have been formatted withmake rpc-format
and compiled withmake rpc
(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
make check
does not fail any testsgo vet
does not report any issuesmake lint
does not report any new issues that did notalready exist
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.