routerrpc+lncli: enable subserver by default and switch over lncli sendpayment #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
default-routerrpc
branch
from
04d9b41
to
e6a1172
Compare
cfromknecht
reviewed
Mar 30, 2020
| Usage: "a zpay32 encoded payment request to fulfill", | ||
| }, | ||
| cli.Int64Flag{ | ||
| Name: "fee_limit", |
There was a problem hiding this comment.
not blocking, but could be a good time to rename this to fee_limit_sat to match fee_limit_percent so they both have units
There was a problem hiding this comment.
I am in doubt about it. It can be done at any time really too. This parameter already existed.
|
Todo: switch over integration tests to |
joostjager
force-pushed
the
default-routerrpc
branch
3 times, most recently
from
56ee174
to
325452c
Compare
|
Itests switched over. Revealed one bug where routerrpc wasn't setting the payment request, see |
cfromknecht
reviewed
Mar 31, 2020
joostjager
force-pushed
the
default-routerrpc
branch
3 times, most recently
from
4b61836
to
fe5d73a
Compare
joostjager
force-pushed
the
default-routerrpc
branch
from
fe5d73a
to
9a181c8
Compare
bhandras
reviewed
Mar 31, 2020
joostjager
force-pushed
the
default-routerrpc
branch
2 times, most recently
from
f965f6b
to
814735b
Compare
joostjager
force-pushed
the
default-routerrpc
branch
from
814735b
to
cdf9be5
Compare
|
Moved itest conversion into separate PR #4132 |
With multi-part payments, a payment-level route field does not make sense anymore.
There is an alternative in routerrpc now. It doesn't support REST yet, but the main rpc SendPayment with its bidirectional streaming isn't usable via REST either. SendPaymentSync still serves REST users and cannot be deprecated yet.
joostjager
force-pushed
the
default-routerrpc
branch
from
cdf9be5
to
3191b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the conditional compilation logic from
routerrpc. It will be enabled by default. This is not a big change, as it was already enabled in our pre-built binary releases.With
routerrpcbeing available always,lnclican be switched over to using theSendPaymentcall on the sub-server.The old main rpc
SendPaymentandSendPaymentSynccalls are marked as deprecated and expected to be removed in the next major release 0.11.Note: SendToRoute will be switched over too, but after #3970 lands.