lnd: fix regression in DB open time logs #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we fix a regression in our DB open time logging that was introduced in lightningnetwork#4015. Obtaining the target backend from the configuration will actually also open the database, so we need to include that in the time delta as well.
cfromknecht
approved these changes
May 22, 2020
|
Tested, working great. Back to seconds instead of milliseconds. ;-)
|
bhandras
approved these changes
May 23, 2020
| @@ -260,7 +261,6 @@ func Main(cfg *Config, lisCfg ListenerCfg, shutdownChan <-chan struct{}) error { | |||
|
|
|||
| // Open the channeldb, which is dedicated to storing channel, and | |||
| // network related metadata. | |||
| startOpenTime := time.Now() | |||
There was a problem hiding this comment.
Sorry for this and Thanks! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we fix a regression in our DB open time logging that was
introduced in #4015. Obtaining the target backend from the configuration
will actually also open the database, so we need to include that in the time
delta as well.