Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoices/sqldb: query by ChanID when updating AMP invoice preimage #9022

Closed
wants to merge 7 commits into from
Closed

invoices/sqldb: query by ChanID when updating AMP invoice preimage #9022

wants to merge 7 commits into from

Commits on Aug 30, 2024

  1. invoices/sqldb: query by ChanID when updating AMP invoice preimage

    @aakselrod @guggero
    aakselrod authored and guggero committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0ab1649 View commit details
    Browse the repository at this point in the history

  2. docs: add release note

    @aakselrod @guggero
    aakselrod authored and guggero committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2514ff3 View commit details
    Browse the repository at this point in the history

  3. itest: check that AMP subinvoices are correctly updated w/nativesql

    @aakselrod @guggero
    aakselrod authored and guggero committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0d430b4 View commit details
    Browse the repository at this point in the history

  4. invoices: ensure AMP subinvoices are correctly updated w/nativesql

    @aakselrod @guggero
    aakselrod authored and guggero committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4a3a3c7 View commit details
    Browse the repository at this point in the history

  5. channeldb: filter AMP state to relevant set IDs 

    When fetching an AMP invoice we sometimes filter HTLCs to selected set
IDs, however we always kept the full AMP state which is irrelevant as it
contains state for all AMP payments. This was a side effect of
UpdateInvoice needing to serialize the whole invoice when storing after
an update but it is an unwanted "feature" as users will need to filter
to relevant set when listing an AMP payment or subsribing to an update.
    @bhandras
    bhandras committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    30f46f2 View commit details
    Browse the repository at this point in the history

  6. sqldb+invoices: synchronize SQL invoice updater behavior with KV version 

    Previously SQL invoice updater ignored the set ID hint when updating an
AMP invoice resulting in update subscriptions returning all of the AMP
state as well as all AMP HTLCs. This commit synchornizes behavior with
the KV implementation such that we now only return relevant AMP state
and HTLCs when updating an AMP invoice.
    @bhandras
    bhandras committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ac60e39 View commit details
    Browse the repository at this point in the history

  7. sqldb: fix end date filter when querying invoices 

    Previously, the SQL implementation of the invoice query simply
converted the start and end timestamps to time and used them
in SQL queries to check for inclusivity. However, this logic
failed when the start and end timestamps were equal.

This commit addresses and corrects this issue.
    @bhandras
    bhandras committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    df4f378 View commit details
    Browse the repository at this point in the history